dialects: (pdl) simplify rewrite pattern and implementations #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 87.25% 87.27% +0.02%
==========================================
Files 145 145
Lines 21411 21391 -20
Branches 3224 3220 -4
==========================================
- Hits 18682 18669 -13
+ Misses 2223 2219 -4
+ Partials 506 503 -3
☔ View full report in Codecov by Sentry. |
math-fehr
approved these changes
Jun 19, 2023
| operation fits the specified pattern and, if so, assigns the xDSL values | ||
| to the corresponding PDL SSA values, and runs the rewrite operations one by | ||
| one. The implementations in this class are for the RHS of the rewrite. | ||
| The implementations in this class are for the RHS of the rewrite. |
There was a problem hiding this comment.
Can you add a more detailed documentation here?
What does this do? Is it the interpreter for a pdl.rewrite?
Has the operation already been matched? Where are they stored?
| @@ -209,17 +221,10 @@ def match_and_rewrite(self, xdsl_op: Operation, rewriter: PatternRewriter) -> No | |||
| @dataclass | |||
| class PDLFunctions(InterpreterFunctions): | |||
There was a problem hiding this comment.
Should you rename this since this only interpret the RHS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the interpretation of the rewrite a bit less convoluted. Instead of interpreting the whole module, the rewrite pattern now interprets just the RewriteOp.