Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add impl_terminator annotation and leverage in interpretation #1165

Merged
merged 6 commits into from Jun 20, 2023

Conversation

superlopuh
Copy link
Member

No description provided.

@superlopuh superlopuh added the API Related to changes regarding API of constructs label Jun 20, 2023
@superlopuh superlopuh self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 80.95% and project coverage change: +0.15 🎉

Comparison is base (0d741b6) 88.46% compared to head (e38fe73) 88.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
+ Coverage   88.46%   88.62%   +0.15%     
==========================================
  Files         156      156              
  Lines       22004    22022      +18     
  Branches     3302     3307       +5     
==========================================
+ Hits        19465    19516      +51     
+ Misses       2007     1975      -32     
+ Partials      532      531       -1     
Impacted Files Coverage Δ
docs/Toy/toy/interpreter.py 54.21% <50.00%> (-0.67%) ⬇️
xdsl/interpreter.py 76.62% <83.78%> (+6.16%) ⬆️
xdsl/interpreters/experimental/pdl.py 73.25% <100.00%> (-0.76%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

docs/Toy/toy/interpreter.py Show resolved Hide resolved
xdsl/interpreter.py Outdated Show resolved Hide resolved
@math-fehr math-fehr self-requested a review June 20, 2023 11:21
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@superlopuh superlopuh merged commit 80612f9 into main Jun 20, 2023
12 checks passed
@superlopuh superlopuh deleted the sasha/interpreter/terminator branch June 20, 2023 12:22
return annot


def impl_terminator(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to changes regarding API of constructs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants