New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (func) Add custom syntax for func.return #1168
Conversation
The print and parse methods should be able to be lifted to |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
==========================================
- Coverage 88.63% 88.61% -0.02%
==========================================
Files 158 158
Lines 22148 22180 +32
Branches 3318 3326 +8
==========================================
+ Hits 19630 19654 +24
- Misses 1985 1990 +5
- Partials 533 536 +3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT 👍
It indeed seems that many dialects need such an operation to return controlflow back out of a region. Therefore, I think that would be a good idea 👍 Not for this PR though, I really like the self-containedness of this one. Maybe open a starter issue? |
This PR:
__init__
constructor forfunc.Return
, deprecating the old one.