misc: Add makefile and update readme #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 88.66% 88.68% +0.01%
==========================================
Files 160 160
Lines 22300 22343 +43
Branches 3345 3355 +10
==========================================
+ Hits 19773 19815 +42
Misses 1989 1989
- Partials 538 539 +1 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Jun 21, 2023
compor
reviewed
Jun 21, 2023
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
compor
approved these changes
Jun 21, 2023
compor
reviewed
Jun 21, 2023
compor
reviewed
Jun 21, 2023
webmiche
approved these changes
Jun 21, 2023
webmiche
reviewed
Jun 21, 2023
Comment on lines
+51
to
+54
| black: | ||
| staged_files="$(shell git diff --staged --name-only)" | ||
| # run black on all of xdsl if no staged files exist | ||
| black $${staged_files:-xdsl} |
There was a problem hiding this comment.
This also runs black on files that are not Python files. This is not an issue in the pyright case above, since pyright realises that and still works, but black complains.
Not sure we really care, just another minor inconvenience
There was a problem hiding this comment.
I have not cared so far, maybe we can fix that in an upcoming PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Makefilecontaining a collection of common tasks in the project.