Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: use black to format notebooks #1185

Merged
merged 3 commits into from Jun 23, 2023
Merged

misc: use black to format notebooks #1185

merged 3 commits into from Jun 23, 2023

Conversation

superlopuh
Copy link
Member

not sure if this is new but there's a formatter for notebooks that the cli just told me about, feels like we should use it

@superlopuh superlopuh added the minor For minor PRs, easy and quick to review, quickly mergeable label Jun 23, 2023
@superlopuh superlopuh self-assigned this Jun 23, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (740c1dd) 88.65% compared to head (fb47134) 88.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files         160      160           
  Lines       22464    22464           
  Branches     3393     3393           
=======================================
  Hits        19916    19916           
  Misses       2004     2004           
  Partials      544      544           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's nice!
Can you add this to the CI as well+

@superlopuh
Copy link
Member Author

It's already in the CI :) Black runs on notebooks by default if the notebooks option is installed

@superlopuh superlopuh merged commit fc113c1 into main Jun 23, 2023
12 checks passed
@superlopuh superlopuh deleted the sasha/black-jupyter branch June 23, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants