Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Factor BaseParser out of the parser (NFC) #1191

Merged
merged 2 commits into from Jun 26, 2023
Merged

Conversation

math-fehr
Copy link
Collaborator

Currently, parser/core.py is a huge file that should be factored more.
This first PR factors out BaseParser out of that file, which contains the mains methods that are used in the different parsers we will have (AffineParser, BuiltinAttrParser, AsmParser).

Factoring this also helps understanding what base functions are available.

This PR only moves methods, and improve a bit on some documentation, but has no functional change.

@math-fehr math-fehr added the core xDSL core (ir, textual format, ...) label Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 95.16% and no project coverage change.

Comparison is base (3b930bf) 88.75% compared to head (6cc233c) 88.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1191   +/-   ##
=======================================
  Coverage   88.75%   88.76%           
=======================================
  Files         161      162    +1     
  Lines       22455    22458    +3     
  Branches     3409     3411    +2     
=======================================
+ Hits        19931    19934    +3     
  Misses       1981     1981           
  Partials      543      543           
Impacted Files Coverage Δ
xdsl/parser/base_parser.py 94.87% <94.87%> (ø)
xdsl/parser/affine_parser.py 90.41% <100.00%> (+0.13%) ⬆️
xdsl/parser/core.py 83.22% <100.00%> (-2.35%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@webmiche webmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass, so I'm fine with this 👍

@math-fehr math-fehr merged commit 2ef53ae into main Jun 26, 2023
12 checks passed
@math-fehr math-fehr deleted the fehr/base-parser branch June 26, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants