misc: reorder test execution order in Makefile #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
AntonLydike,
JosseVanDelm and
adutilleul
superlopuh
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
|
Oh actually I just realised that currently the toy pytest tests aren't executed, this adds them. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 164 164
Lines 22543 22543
Branches 3409 3409
=======================================
Hits 20017 20017
Misses 1982 1982
Partials 544 544 ☔ View full report in Codecov by Sentry. |
compor
approved these changes
Jun 27, 2023
adutilleul
approved these changes
Jun 27, 2023
webmiche
approved these changes
Jun 27, 2023
|
Run previously failing tests first :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lowers the expected time to see an error, since notebook tests are the slowest to run, and the least likely to break. I also split out the toy tests to their own target since that's something I run a lot when working on that bit of code, all that does is change the order of execution.