Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: Remove deprecated builtin constructors #1203

Merged
merged 1 commit into from Jun 27, 2023

Conversation

math-fehr
Copy link
Collaborator

We marked these deprecated long ago that now no one should use them anymore.

@math-fehr math-fehr added the core xDSL core (ir, textual format, ...) label Jun 27, 2023
@math-fehr math-fehr requested a review from webmiche as a code owner June 27, 2023 13:38
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (512f1d5) 88.79% compared to head (019f3fc) 88.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
+ Coverage   88.79%   88.84%   +0.05%     
==========================================
  Files         164      164              
  Lines       22543    22477      -66     
  Branches     3409     3407       -2     
==========================================
- Hits        20017    19970      -47     
+ Misses       1982     1963      -19     
  Partials      544      544              
Impacted Files Coverage Δ
xdsl/dialects/builtin.py 84.80% <ø> (+1.40%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@webmiche webmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this more than one major version ago? IF so, I am fine with this.

@math-fehr
Copy link
Collaborator Author

Was this more than one major version ago? IF so, I am fine with this.

4 months ago, so probably 2-3 major versions

@webmiche webmiche merged commit 2ad3624 into main Jun 27, 2023
12 checks passed
@webmiche webmiche deleted the fehr/remove-deprecated branch June 27, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants