interpreter: (cf) add cf interpreter functions and extend arith #1217
Conversation
superlopuh
requested review from
tobiasgrosser,
compor,
AntonLydike,
JosseVanDelm,
PapyChacal and
adutilleul
superlopuh
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
==========================================
+ Coverage 88.66% 88.90% +0.23%
==========================================
Files 167 169 +2
Lines 22873 22976 +103
Branches 3478 3498 +20
==========================================
+ Hits 20280 20426 +146
+ Misses 2038 1993 -45
- Partials 555 557 +2
☔ View full report in Codecov by Sentry. |
xdsl/interpreters/arith.py
Outdated
There was a problem hiding this comment.
I guess we see here one of the limitations of the Pyhton-based interpreter: Modellling fixed-size integers is nasty in Python. That's also why signed an unsigned are not distinguished in Python...
But I guess as long as we stay within reasonable boundaries, this should not matter.
There was a problem hiding this comment.
Yeah, I guess the problem here is that our interpreter should also take into account bitwidth, which it doesn't now!
| def triangle_fn(n: int) -> int: | ||
| result = 0 | ||
| i = 0 | ||
| while i <= n: |
There was a problem hiding this comment.
This can be done better?
There was a problem hiding this comment.
Is that a question or an assertion? the whole function is n * (n-1) // 2 so can be done better indeed :)
superlopuh
force-pushed
the
sasha/interpreter/cf
branch
from
469a826
to
ee034bc
Compare
No description provided.