documentation: (toy) toy cli interprets by default #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1223 +/- ##
=======================================
Coverage 88.96% 88.96%
=======================================
Files 170 172 +2
Lines 23244 23331 +87
Branches 3529 3540 +11
=======================================
+ Hits 20678 20756 +78
- Misses 2003 2009 +6
- Partials 563 566 +3 ☔ View full report in Codecov by Sentry. |
webmiche
approved these changes
Jul 3, 2023
| if target == "toy-infer-shapes": | ||
| return | ||
|
|
||
| raise ValueError(f"Unknown target option {target}") |
There was a problem hiding this comment.
Why are you doing all the transforms just to fail later on? Wouldn't it make more sense to just fail early?
There was a problem hiding this comment.
Mostly because modifying the strings in three places is tedious. argparse will already have checked for the options before calling this function, so it's only if for some reason someone calls it from python code somehow, and to make Pyright happy since it doesn't know that there is a closed set of options possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.