misc: fix diagnostic region printing #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
added
bug
superlopuh
requested review from
tobiasgrosser,
compor,
georgebisbas,
JosseVanDelm,
PapyChacal,
webmiche and
adutilleul
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1227 +/- ##
==========================================
+ Coverage 88.96% 88.97% +0.01%
==========================================
Files 170 174 +4
Lines 23244 23385 +141
Branches 3529 3544 +15
==========================================
+ Hits 20678 20806 +128
- Misses 2003 2013 +10
- Partials 563 566 +3
☔ View full report in Codecov by Sentry. |
compor
approved these changes
Jul 4, 2023
georgebisbas
approved these changes
Jul 4, 2023
adutilleul
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
# type: ignoreconsidered harmful...I hit this while working on Toy