Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: Remove redundant r mode in open #1249

Merged
merged 2 commits into from Jul 7, 2023
Merged

python: Remove redundant r mode in open #1249

merged 2 commits into from Jul 7, 2023

Conversation

kingiler
Copy link
Collaborator

@kingiler kingiler commented Jul 7, 2023

No description provided.

@kingiler kingiler added enhancement New feature or request minor For minor PRs, easy and quick to review, quickly mergeable labels Jul 7, 2023
@kingiler kingiler mentioned this pull request Jul 7, 2023
Closed
9 tasks
@codecov
Copy link

codecov bot commented Jul 7, 2023 •
edited

Codecov Report

Patch coverage: 90.90% and no project coverage change.

Comparison is base (e38225e) 88.93% compared to head (b154242) 88.93%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1249   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files         175      175           
  Lines       23642    23642           
  Branches     3587     3587           
=======================================
  Hits        21026    21026           
  Misses       2044     2044           
  Partials      572      572
Impacted Files Coverage Δ
docs/Toy/toy/frontend/lexer.py 86.90% <0.00%> (ø)
docs/Toy/toy/tests/test_ir_gen.py 100.00% <100.00%> (ø)
docs/Toy/toy/tests/test_parser.py 100.00% <100.00%> (ø)
tests/xdsl_opt/test_xdsl_opt.py 98.95% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

math-fehr
math-fehr approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@math-fehr math-fehr merged commit db4d5b3 into xdslproject:main Jul 7, 2023
10 checks passed
@kingiler kingiler deleted the update_python_syntax branch July 7, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@math-fehr math-fehr math-fehr approved these changes

@superlopuh superlopuh Awaiting requested review from superlopuh

@webmiche webmiche Awaiting requested review from webmiche

@compor compor Awaiting requested review from compor

@georgebisbas georgebisbas Awaiting requested review from georgebisbas

@AntonLydike AntonLydike Awaiting requested review from AntonLydike

Assignees
No one assigned
Labels
enhancement New feature or request minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kingiler @math-fehr