reqs: add typing-extension dependency #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
added
dependencies
superlopuh
requested review from
tobiasgrosser,
compor,
AntonLydike,
PapyChacal,
kingiler and
adutilleul
superlopuh
changed the title
superlopuh
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
==========================================
+ Coverage 89.10% 89.12% +0.01%
==========================================
Files 181 181
Lines 24124 24075 -49
Branches 3667 3668 +1
==========================================
- Hits 21496 21457 -39
+ Misses 2048 2040 -8
+ Partials 580 578 -2
☔ View full report in Codecov by Sentry. |
superlopuh
changed the title
superlopuh
requested review from
math-fehr,
webmiche and
georgebisbas
as code owners
webmiche
reviewed
Jul 12, 2023
|
Yeah ideally we'd drop it as soon as we drop 3.10 |
compor
approved these changes
Jul 13, 2023
adutilleul
approved these changes
Jul 13, 2023
kingiler
requested changes
Jul 13, 2023
requirements.txt
Outdated
| @@ -1,2 +1,3 @@ | |||
| pip<24.0 | |||
| immutabledict<2.2.6 | |||
| typing-extensions<4.8 | |||
There was a problem hiding this comment.
Suggested change
| typing-extensions<4.8 | |
| typing-extensions>=4.8,<5 |
as suggested on the homepage.
There was a problem hiding this comment.
I'll give it a go, although it might not work with some of the dependency tracking tools, will report back
There was a problem hiding this comment.
It worked! I was too pessimistic. Let's see how dependabot deals with the update
PapyChacal
approved these changes
Jul 13, 2023
math-fehr
approved these changes
Jul 13, 2023
kingiler
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self is a very useful type to have available, introduced in 3.11. In Python 3.10 a third-party module is required for the same functionality. I reckon the extra dependency is worth it for the kind of thing we'd like to express.
It seems to me like it's necessary to make it a required dependency as core code should be able to use Self, so users of pip install should inherit it as well. It's a bit annoying to have a dependency that's only required for python 3.10 but it seems worth it to me.