New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (riscv) Refactor register allocaton strategies #1266
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
==========================================
+ Coverage 89.12% 89.16% +0.03%
==========================================
Files 181 181
Lines 24073 24069 -4
Branches 3667 3657 -10
==========================================
+ Hits 21455 21460 +5
+ Misses 2040 2037 -3
+ Partials 578 572 -6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small comments, otherwise LGTM
This PR:
is_allocated
helper method/property to the register types (factored out from one of the strategies)RegisterType
/FloatRegisterType
) across all strategies