Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Improve exception #1272

Merged
merged 2 commits into from Jul 14, 2023
Merged

core: Improve exception #1272

merged 2 commits into from Jul 14, 2023

Conversation

kingiler
Copy link
Collaborator

  • core: Improve exception
  • docs: Update docs

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (03b2de6) 89.12% compared to head (da1b3f1) 89.12%.

❗ Current head da1b3f1 differs from pull request most recent head 843fd30. Consider uploading reports for the commit 843fd30 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1272      +/-   ##
==========================================
- Coverage   89.12%   89.12%   -0.01%     
==========================================
  Files         181      181              
  Lines       24075    24074       -1     
  Branches     3668     3668              
==========================================
- Hits        21457    21456       -1     
  Misses       2040     2040              
  Partials      578      578              
Impacted Files Coverage Δ
xdsl/irdl.py 92.04% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@math-fehr math-fehr added the core xDSL core (ir, textual format, ...) label Jul 13, 2023
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kingiler kingiler merged commit be0c6c8 into xdslproject:main Jul 14, 2023
8 of 9 checks passed
@kingiler kingiler deleted the improve_exception branch July 14, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants