Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (linalg) Add linalg methods to determine loop range #1279

Merged
merged 6 commits into from Jul 18, 2023

Conversation

Groverkss
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 88.70% and project coverage change: +0.17 🎉

Comparison is base (ea17fb4) 89.32% compared to head (db524ca) 89.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
+ Coverage   89.32%   89.50%   +0.17%     
==========================================
  Files         180      184       +4     
  Lines       24000    24270     +270     
  Branches     3652     3682      +30     
==========================================
+ Hits        21439    21722     +283     
+ Misses       1989     1967      -22     
- Partials      572      581       +9     
Impacted Files Coverage Δ
xdsl/ir/affine/affine_map.py 90.00% <64.28%> (-10.00%) ⬇️
xdsl/dialects/linalg.py 89.65% <93.54%> (+2.15%) ⬆️
tests/dialects/test_linalg.py 100.00% <100.00%> (ø)

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had two questions relative to documentation, but otherwise that looks good to me!

xdsl/ir/affine/affine_map.py Show resolved Hide resolved
xdsl/dialects/linalg.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@webmiche webmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

xdsl/dialects/linalg.py Outdated Show resolved Hide resolved
xdsl/dialects/linalg.py Outdated Show resolved Hide resolved
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo some list comprehensions that IMO make code a little more readable, and that have better perf in Python than for loops and maps

xdsl/dialects/linalg.py Show resolved Hide resolved
xdsl/dialects/linalg.py Outdated Show resolved Hide resolved
xdsl/dialects/linalg.py Outdated Show resolved Hide resolved
Groverkss and others added 3 commits July 17, 2023 19:34
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
@superlopuh superlopuh merged commit ec75bbd into xdslproject:main Jul 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants