New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (linalg) Add linalg methods to determine loop range #1279
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
+ Coverage 89.32% 89.50% +0.17%
==========================================
Files 180 184 +4
Lines 24000 24270 +270
Branches 3652 3682 +30
==========================================
+ Hits 21439 21722 +283
+ Misses 1989 1967 -22
- Partials 572 581 +9
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had two questions relative to documentation, but otherwise that looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo some list comprehensions that IMO make code a little more readable, and that have better perf in Python than for loops and maps
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
No description provided.