Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: (parser) Make parsing for function type public #1297

Merged
merged 2 commits into from Jul 18, 2023
Merged

core: (parser) Make parsing for function type public #1297

merged 2 commits into from Jul 18, 2023

Conversation

kingiler
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (401feee) 89.60% compared to head (b3c61c8) 89.60%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1297   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files         187      187           
  Lines       24540    24540           
  Branches     3695     3695           
=======================================
  Hits        21989    21989           
  Misses       1970     1970           
  Partials      581      581
Impacted Files Coverage Δ
xdsl/parser/attribute_parser.py 75.26% <100.00%> (ø)
xdsl/parser/core.py 89.76% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kingiler kingiler self-assigned this Jul 18, 2023
@kingiler kingiler marked this pull request as ready for review July 18, 2023 16:37
@kingiler kingiler added enhancement New feature or request API Related to changes regarding API of constructs minor For minor PRs, easy and quick to review, quickly mergeable core xDSL core (ir, textual format, ...) labels Jul 18, 2023
math-fehr
math-fehr approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AntonLydike AntonLydike merged commit 7d0184c into main Jul 18, 2023
10 checks passed
@AntonLydike AntonLydike deleted the parser_func_type branch July 18, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonLydike AntonLydike AntonLydike approved these changes

@math-fehr math-fehr math-fehr approved these changes

@webmiche webmiche Awaiting requested review from webmiche

@georgebisbas georgebisbas Awaiting requested review from georgebisbas

Assignees

@kingiler kingiler

Labels
API Related to changes regarding API of constructs core xDSL core (ir, textual format, ...) enhancement New feature or request minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kingiler @AntonLydike @math-fehr