misc: make pyright only runs on .py files #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
added
the
minor
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1308 +/- ##
==========================================
- Coverage 89.61% 89.61% -0.01%
==========================================
Files 187 187
Lines 24566 24560 -6
Branches 3693 3691 -2
==========================================
- Hits 22016 22010 -6
Misses 1968 1968
Partials 582 582 ☔ View full report in Codecov by Sentry. |
adutilleul
approved these changes
Jul 20, 2023
AntonLydike
approved these changes
Jul 20, 2023
Makefile
Outdated
Comment on lines
57
to
59
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Whitespace change? Or was formatting off before?
There was a problem hiding this comment.
ah my b this was the test :)
webmiche
approved these changes
Jul 20, 2023
|
Do we want |
|
That's a good question, I'll add it and see what happens |
|
those are json so it doesn't know what to do with them. I'll merge as-is and we can deal with the pyright later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I frequently run
make tests(thanks again) and this is minor noise when the diff contains files that aren't Python.