Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Rename _OpT to IRDLOperationInvT (NFC) #1310

Merged
merged 3 commits into from Jul 21, 2023
Merged

Conversation

math-fehr
Copy link
Collaborator

This renames _OpT to IRDLOperationInvT, and also adds covariant and contravariant versions.

@math-fehr math-fehr added the core xDSL core (ir, textual format, ...) label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f71afcd) 89.63% compared to head (3a279c9) 89.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1310   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         187      187           
  Lines       24574    24576    +2     
  Branches     3690     3690           
=======================================
+ Hits        22026    22028    +2     
  Misses       1967     1967           
  Partials      581      581           
Impacted Files Coverage Δ
xdsl/irdl.py 92.06% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tobiasgrosser tobiasgrosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed seems more readable.

Copy link
Collaborator

@webmiche webmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

xdsl/irdl.py Show resolved Hide resolved
@math-fehr math-fehr merged commit 6c83a54 into main Jul 21, 2023
10 checks passed
@math-fehr math-fehr deleted the fehr/irdlop-inv branch July 21, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants