Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: Add attributes and __init__ to gpu.FuncOp #1320

Merged
merged 1 commit into from Jul 22, 2023

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Jul 21, 2023

Add gpu.known_block_size and gpu.known_grid_size to gpu.func.
Add __init__ to gpu.FuncOp.

@PapyChacal PapyChacal added the dialects Changes on the dialects label Jul 21, 2023
@PapyChacal PapyChacal self-assigned this Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.01 ⚠️

Comparison is base (6c83a54) 89.63% compared to head (f9fa30d) 89.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
- Coverage   89.63%   89.62%   -0.01%     
==========================================
  Files         187      187              
  Lines       24576    24608      +32     
  Branches     3690     3699       +9     
==========================================
+ Hits        22028    22055      +27     
  Misses       1967     1967              
- Partials      581      586       +5     
Impacted Files Coverage Δ
xdsl/dialects/gpu.py 97.36% <62.50%> (-1.41%) ⬇️
tests/dialects/test_gpu.py 100.00% <100.00%> (ø)
xdsl/parser/core.py 90.48% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tobiasgrosser
Copy link
Contributor

Nice. This looks helpful.

@PapyChacal PapyChacal merged commit a852bad into main Jul 22, 2023
10 checks passed
@PapyChacal PapyChacal deleted the emilien/gpu-known-attributes branch July 22, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants