Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: more detailed error message in pass from spec #1329

Merged
merged 2 commits into from Jul 25, 2023

Conversation

superlopuh
Copy link
Member

This helped me debug some things before.

@superlopuh superlopuh added the minor For minor PRs, easy and quick to review, quickly mergeable label Jul 24, 2023
@superlopuh superlopuh self-assigned this Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (a4a2dcf) 89.62% compared to head (3b1e94b) 89.65%.

❗ Current head 3b1e94b differs from pull request most recent head 483bd9f. Consider uploading reports for the commit 483bd9f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
+ Coverage   89.62%   89.65%   +0.02%     
==========================================
  Files         187      191       +4     
  Lines       24616    24871     +255     
  Branches     3699     3752      +53     
==========================================
+ Hits        22063    22297     +234     
- Misses       1967     1982      +15     
- Partials      586      592       +6     
Files Changed Coverage Δ
tests/test_pass_from_spec.py 93.33% <100.00%> (+0.15%) ⬆️
xdsl/passes.py 92.72% <100.00%> (+0.27%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xdsl/passes.py Outdated Show resolved Hide resolved
@superlopuh superlopuh merged commit 5fe8da1 into main Jul 25, 2023
9 checks passed
@superlopuh superlopuh deleted the sasha/wm/pass-from-spec-error branch July 25, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants