dialects: Migrate func dialect to use init from get methods #1333
Conversation
ShaolunWang
added
enhancement
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
- Coverage 89.64% 89.63% -0.01%
==========================================
Files 191 191
Lines 24868 24873 +5
Branches 3750 3751 +1
==========================================
+ Hits 22294 22296 +2
- Misses 1982 1985 +3
Partials 592 592
☔ View full report in Codecov by Sentry. |
|
|
||
| @deprecated("Use func.Call(...) instead!") | ||
| @staticmethod | ||
| def get( |
There was a problem hiding this comment.
Do we need the get now? Isn't it replaced everywhere it was referenced?
In other words, what I'm asking is when to deprecate the public API and how should we go about it in general @math-fehr ?
There was a problem hiding this comment.
I'm actually not completely sure, but I would suggest to keep it deprecated for at least one release?
I don't think we break much of the public API anymore, so I guess we should be careful.
That being said, I recall others saying that we should probably just remove it.
#1120: Migrate
func.Callto use init from get methods