Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpreter: Use sym_name when translating a gpu.func to WGSL. #1340

Merged
merged 1 commit into from Jul 25, 2023

Conversation

PapyChacal
Copy link
Collaborator

Just using the actual function name when translating it to WGSL. Will be useful for the upcoming WGPU interpreter!

@PapyChacal PapyChacal added the interpreter xDSL Interpreter label Jul 25, 2023
@PapyChacal PapyChacal self-assigned this Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5fe8da1) 89.65% compared to head (38d6c0f) 89.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1340   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files         191      191           
  Lines       24909    24909           
  Branches     3758     3758           
=======================================
  Hits        22331    22331           
  Misses       1984     1984           
  Partials      594      594           
Files Changed Coverage Δ
tests/interpreters/test_wgsl_printer.py 100.00% <ø> (ø)
xdsl/interpreters/experimental/wgsl_printer.py 96.17% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal merged commit 5394ea9 into main Jul 25, 2023
10 checks passed
@PapyChacal PapyChacal deleted the emilien/wgpu-func-name branch July 25, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter xDSL Interpreter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants