documentation: (toy) add toy accelerator dialect #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
georgebisbas,
JosseVanDelm,
PapyChacal,
webmiche,
kingiler and
adutilleul
superlopuh
commented
Jul 25, 2023
| @@ -441,17 +441,6 @@ class LowerToAffinePass(ModulePass): | |||
| name = "toy-to-builtin" | |||
|
|
|||
| def apply(self, ctx: MLContext, op: ModuleOp) -> None: | |||
| # We define the specific operations, or dialects, that are legal targets for this | |||
There was a problem hiding this comment.
I initially copied this logic from the Toy tutorial, but it broke when I passed in an MLIR file directly, which ought to work. I don't think we really need to replicate this part of the tutorial for the time being
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1342 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 191 191
Lines 24909 25007 +98
Branches 3758 3769 +11
=======================================
+ Hits 22331 22420 +89
- Misses 1984 1992 +8
- Partials 594 595 +1 ☔ View full report in Codecov by Sentry. |
AntonLydike
approved these changes
Jul 26, 2023
math-fehr
approved these changes
Jul 27, 2023
| @@ -4,6 +4,8 @@ | |||
| # RUN: python -m toy %s --emit=toy-infer-shapes | filecheck %s | |||
| # RUN: python -m toy %s --emit=affine | filecheck %s | |||
|
|
|||
| # RUN: python -m toy %s --emit=affine --accelerate | filecheck %s | |||
There was a problem hiding this comment.
Did you check that this run? I'm not sure if things run if they are not in the first lines.
There was a problem hiding this comment.
Added an assert False, seems to work ok
| @@ -1,5 +1,7 @@ | |||
| # RUN: python -m toy %s --emit=scf | filecheck %s | |||
|
|
|||
| # RUN: python -m toy %s --emit=scf --accelerate | filecheck %s | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is to show how to divert the compilation flow to a toy accelerator. This is much simpler than the plan with snitch etc, but still shows the vague idea of matching on affine loops and raising them to a different builtin operation.
As part of the Toy compilation, we know that the accelerator matches all the possible affine loops that we create, meaning that we can compile it end-to-end in python without relying on MLIR.