New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialect: Deprecating .get
in llvm dialect
#1349
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1349 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 191 191
Lines 24939 25007 +68
Branches 3760 3769 +9
=======================================
+ Hits 22358 22420 +62
- Misses 1987 1992 +5
- Partials 594 595 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is much easier to review once you make get
just call __init__
... Otherwise it looks good! Thanks!
Making respective changes from .get to __init__ in mpi lowering and tests
Rebased this so github can actually show my changes here 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks!
Making respective changes from .get to init in mpi lowering and llvm/mpi tests