Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (riscv) Add scf-to-riscv pass #1356

Merged
merged 17 commits into from Aug 4, 2023
Merged

dialects: (riscv) Add scf-to-riscv pass #1356

merged 17 commits into from Aug 4, 2023

Conversation

AntonLydike
Copy link
Collaborator

Add a pass scf-to-riscv that converts scf for ops to riscv.for, for register allocation afterwards.

Missing tests currently.

@AntonLydike AntonLydike added the transformations Changes or adds a transformatio label Jul 27, 2023
@AntonLydike AntonLydike self-assigned this Jul 27, 2023
@AntonLydike AntonLydike changed the title add scf-to-riscv pass dialects: (riscv) Add scf-to-riscv pass Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 99.14% and project coverage change: +0.04% 🎉

Comparison is base (18a0b7e) 89.99% compared to head (72d5192) 90.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   89.99%   90.04%   +0.04%     
==========================================
  Files         209      212       +3     
  Lines       26155    26272     +117     
  Branches     3897     3907      +10     
==========================================
+ Hits        23539    23657     +118     
+ Misses       2003     2002       -1     
  Partials      613      613              
Files Changed Coverage Δ
xdsl/backend/riscv/lowering/utils.py 96.55% <96.55%> (ø)
tests/backend/riscv/test_utils.py 100.00% <100.00%> (ø)
xdsl/backend/riscv/lowering/scf_to_riscv_scf.py 100.00% <100.00%> (ø)
xdsl/tools/command_line_tool.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adutilleul adutilleul self-assigned this Aug 3, 2023
@adutilleul adutilleul marked this pull request as ready for review August 3, 2023 10:15
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYVM

Copy link
Collaborator Author

@AntonLydike AntonLydike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't approve through github as I'm the author, but I approve ✔️

@AntonLydike
Copy link
Collaborator Author

Thanks @adutilleul for this, you basically rewrote everything again!

@superlopuh superlopuh merged commit da6244d into main Aug 4, 2023
10 checks passed
@superlopuh superlopuh deleted the anton/scf-to-rvscf branch August 4, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants