dialect: (riscv) Custom print attributes #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingiler
added
enhancement
kingiler
requested review from
superlopuh,
AntonLydike and
tobiasgrosser
and removed request for
superlopuh and
AntonLydike
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 89.74% 89.75%
=======================================
Files 196 196
Lines 25311 25349 +38
Branches 3803 3811 +8
=======================================
+ Hits 22715 22751 +36
Misses 1998 1998
- Partials 598 600 +2
☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Jul 28, 2023
| args = cls.parse_unresolved_operand(parser) | ||
| custom_attributes = cls.parse_attributes(parser) | ||
| remaining_attributes = parser.parse_optional_attr_dict() | ||
| # TODO ensure distinct keys for attributes |
There was a problem hiding this comment.
Could you please file an issue and reference it in this comment? Feels like it should be common infrastructure
There was a problem hiding this comment.
Filed an issue #1369
adutilleul
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.