documentation: (toy) add initial lowering to riscv #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
tobiasgrosser,
compor,
AntonLydike,
georgebisbas,
math-fehr,
PapyChacal and
adutilleul
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
+ Coverage 89.71% 89.76% +0.04%
==========================================
Files 196 198 +2
Lines 25269 25342 +73
Branches 3800 3807 +7
==========================================
+ Hits 22671 22748 +77
+ Misses 1999 1997 -2
+ Partials 599 597 -2
☔ View full report in Codecov by Sentry. |
superlopuh
commented
Jul 29, 2023
| ) | ||
|
|
||
|
|
||
| class AddSections(RewritePattern): |
There was a problem hiding this comment.
With @AntonLydike's riscemu malloc and friends, the .bss section hack is not necessary, similarly we can probably get away with dropping the data section. I'd like to first merge the end-to-end flow as it's working today, and make it better later, if that's ok with everyone.
AntonLydike
approved these changes
Jul 31, 2023
Comment on lines
+107
to
+110
| DeadCodeElimination().apply(ctx, module_op) | ||
| # ReconcileUnrealizedCastsPass().apply(ctx, module_op) | ||
|
|
||
| DeadCodeElimination().apply(ctx, module_op) |
There was a problem hiding this comment.
Ah yes I guess not really necessary right now, I'll remove it in the next PR
adutilleul
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the structure of the riscv lowering and the first pass. I added some future changes as TODOs so that the remaining work is clear.