dialects: (riscv) add func to riscv_func lowering
#1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutilleul
requested review from
superlopuh,
compor,
AntonLydike,
JosseVanDelm and
kingiler
adutilleul
changed the title
func to riscv_func loweringfunc to riscv_func lowering
adutilleul
changed the title
func to riscv_func loweringadd func to riscv_func lowering
adutilleul
changed the title
add func to riscv_func loweringfunc to riscv_func lowering
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
==========================================
+ Coverage 89.87% 89.90% +0.02%
==========================================
Files 202 204 +2
Lines 25803 25872 +69
Branches 3864 3872 +8
==========================================
+ Hits 23191 23260 +69
Misses 1996 1996
Partials 616 616
☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Aug 1, 2023
|
Seems ready for review |
AntonLydike
approved these changes
Aug 1, 2023
| ) | ||
|
|
||
| new_func = riscv_func.FuncOp( | ||
| op.sym_name.data, rewriter.move_region_contents_to_new_regions(op.body) |
There was a problem hiding this comment.
I did not know we had this API, TIL! Very nice!
Comment on lines
52
to
54
| PatternRewriteWalker(LowerFuncOp()).rewrite_module(op) | ||
| PatternRewriteWalker(LowerFuncCallOp()).rewrite_module(op) | ||
| PatternRewriteWalker(LowerReturnOp()).rewrite_module(op) |
There was a problem hiding this comment.
Can we put these into one walker?
Comment on lines
+33
to
+36
| class LowerFuncCallOp(RewritePattern): | ||
| @op_type_rewrite_pattern | ||
| def match_and_rewrite(self, op: func.Call, rewriter: PatternRewriter) -> None: | ||
| raise NotImplementedError("Function call lowering not implemented yet") |
There was a problem hiding this comment.
Not sure why this is even in the PR, it just does absolutely nothing?
There was a problem hiding this comment.
I like it, it's a nice stub for us to replace later, and then the failing unit tests are replaced with working unit tests, so we get a little win in the future also
Comment on lines
+39
to
+45
| class LowerReturnOp(RewritePattern): | ||
| @op_type_rewrite_pattern | ||
| def match_and_rewrite(self, op: func.Return, rewriter: PatternRewriter): | ||
| if op.arguments: | ||
| raise NotImplementedError("Only support return with no arguments for now") | ||
|
|
||
| rewriter.replace_matched_op(riscv_func.ReturnOp(())) |
There was a problem hiding this comment.
And this is here but not tested, and also quite useless imo?
superlopuh
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a very barebone lowering that will be used by the toy pipeline.