riscv: make CSRRWI immediate mandatory #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingiler
requested changes
Aug 9, 2023
superlopuh
approved these changes
Aug 9, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1431 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 214 214
Lines 26553 26553
Branches 3951 3951
=======================================
Hits 23906 23906
Misses 2018 2018
Partials 629 629
☔ View full report in Codecov by Sentry. |
adutilleul
approved these changes
Aug 9, 2023
Co-authored-by: kingiler <68145845+kingiler@users.noreply.github.com>
kingiler
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immediate argument to
riscv.csrrwiwas marked as optional. Fixed by marking it as mandatory to abide by the ISA.