Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialect: (riscv) Custom syntax for DirectiveOp #1432

Merged
merged 9 commits into from Aug 9, 2023

Conversation

kingiler
Copy link
Collaborator

@kingiler kingiler commented Aug 9, 2023

Custom syntax has been added for DirectiveOp.

New custom syntax will be as follows:

riscv.directive ".align" "2" : () -> ()

Notice the absence of comma between directive and value.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 90.90% and no project coverage change.

Comparison is base (77d5f57) 90.03% compared to head (3fe641f) 90.03%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1432   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files         214      214           
  Lines       26553    26597   +44     
  Branches     3951     3959    +8     
=======================================
+ Hits        23906    23946   +40     
- Misses       2018     2020    +2     
- Partials      629      631    +2     
Files Changed Coverage Δ
xdsl/dialects/riscv.py 86.52% <90.90%> (+0.18%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingiler kingiler self-assigned this Aug 9, 2023
@kingiler kingiler added enhancement New feature or request dialects Changes on the dialects testing PRs that modify tests minor For minor PRs, easy and quick to review, quickly mergeable labels Aug 9, 2023
@kingiler kingiler marked this pull request as ready for review August 9, 2023 10:21
Base automatically changed from custom_syntax_csr to main August 9, 2023 13:03
@kingiler kingiler merged commit f92cc67 into main Aug 9, 2023
10 checks passed
@kingiler kingiler deleted the custom_syntax_directive branch August 9, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects enhancement New feature or request minor For minor PRs, easy and quick to review, quickly mergeable testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants