Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialect: (riscv) Custom syntax for CSR immediate Op #1435

Merged
merged 13 commits into from Aug 9, 2023

Conversation

kingiler
Copy link
Collaborator

@kingiler kingiler commented Aug 9, 2023

Custom syntax has been added for CSR immediate operations.

New custom syntax will be as follows:

%csrrsi_rw = riscv.csrrsi 1024, 8 : () -> !riscv.reg<>
%csrrsi_r = riscv.csrrsi 1024, 0 : () -> !riscv.reg<>
%csrrci_rw = riscv.csrrci 1024, 8 : () -> !riscv.reg<>
%csrrci_r = riscv.csrrci 1024, 0 : () -> !riscv.reg<>
%csrrwi_rw = riscv.csrrwi 1024, 1 : () -> !riscv.reg<>
%csrrwi_w = riscv.csrrwi 1024, 1, "w" : () -> !riscv.reg<>

@kingiler kingiler self-assigned this Aug 9, 2023
@kingiler kingiler added enhancement New feature or request dialects Changes on the dialects testing PRs that modify tests minor For minor PRs, easy and quick to review, quickly mergeable labels Aug 9, 2023
@kingiler kingiler marked this pull request as ready for review August 9, 2023 11:06
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 93.75% and no project coverage change.

Comparison is base (17f0cc9) 90.03% compared to head (71ea42d) 90.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1435   +/-   ##
=======================================
  Coverage   90.03%   90.04%           
=======================================
  Files         214      214           
  Lines       26615    26647   +32     
  Branches     3959     3962    +3     
=======================================
+ Hits        23964    23994   +30     
- Misses       2020     2021    +1     
- Partials      631      632    +1     
Files Changed Coverage Δ
xdsl/dialects/riscv.py 86.93% <93.75%> (+0.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from custom_syntax_float to main August 9, 2023 13:12
@kingiler kingiler merged commit 6e2c30c into main Aug 9, 2023
10 checks passed
@kingiler kingiler deleted the custom_syntax_csrimm branch August 9, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects enhancement New feature or request minor For minor PRs, easy and quick to review, quickly mergeable testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants