New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: (trait) Polish HasParent trait #1438
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
==========================================
- Coverage 90.02% 90.02% -0.01%
==========================================
Files 214 214
Lines 26668 26666 -2
Branches 3965 3964 -1
==========================================
- Hits 24009 24007 -2
Misses 2026 2026
Partials 633 633
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🙂
Main change is the use of
*args
forparameters
. Another change is using generators instead of list.