Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: (trait) Polish HasParent trait #1438

Merged
merged 5 commits into from Aug 10, 2023
Merged

core: (trait) Polish HasParent trait #1438

merged 5 commits into from Aug 10, 2023

Conversation

kingiler
Copy link
Collaborator

@kingiler kingiler commented Aug 9, 2023

Main change is the use of *args for parameters. Another change is using generators instead of list.

@kingiler kingiler self-assigned this Aug 9, 2023
@kingiler kingiler added minor For minor PRs, easy and quick to review, quickly mergeable core xDSL core (ir, textual format, ...) labels Aug 9, 2023
@kingiler kingiler marked this pull request as ready for review August 9, 2023 14:26
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (cd00bd8) 90.02% compared to head (f59141f) 90.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
- Coverage   90.02%   90.02%   -0.01%     
==========================================
  Files         214      214              
  Lines       26668    26666       -2     
  Branches     3965     3964       -1     
==========================================
- Hits        24009    24007       -2     
  Misses       2026     2026              
  Partials      633      633              
Files Changed Coverage Δ
tests/test_builtin_traits.py 100.00% <100.00%> (ø)
xdsl/dialects/irdl/irdl.py 94.97% <100.00%> (ø)
xdsl/traits.py 94.81% <100.00%> (-0.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xdsl/traits.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@PapyChacal PapyChacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙂

@kingiler kingiler merged commit ec6c3ed into main Aug 10, 2023
10 checks passed
@kingiler kingiler deleted the polish_hasparent branch August 10, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...) minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants