Add signedness semantics for integer types #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmiche
approved these changes
Oct 10, 2022
| } | ||
| } | ||
| func.func() ["sym_name" = "tuple_to_tuple", "value" = !fun<[!tuple<[!i32]>], [!tuple<[!i32]>]>, "function_type" = !fun<[], []>] {} | ||
| // CHECK: "value" = !fun<[!tuple<[!i32]>], [!tuple<[!i32]>]> |
There was a problem hiding this comment.
I don't quite get this change. AFAIU, you are using a function operation here to show that !fun<[!tuple<[!i32]>], [!tuple<[!i32]>]> can be parsed/printed. Why use a function operation? Aren't there easier operations to do that with? You can give sym_name and value to any operation to keep the name of the test around as well, right?
I feel like I am confused by these tests each time I see them. Would it make sense to have an empty test.testing operation just to make these tests easier to understand?
There was a problem hiding this comment.
Yeah, I'll add a test.testing in a following PR, that should make things better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds signedness semantics for integer types, as MLIR does.
This PR also fix one test that was failing, but not running on the CI since the MLIR tests are not ran on the CI.
(Note, I should fix in a following PR this, since most of the MLIR files do not need MLIR anymore).