New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLIR target does not include parenthesis around multiple results to f… #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix MLIR parsing error
Thanks, that looks good! |
…xdslproject/xdsl into multiple_results_no_parenthesis # Conflicts: # xdsl/parser.py
…xdslproject/xdsl into multiple_results_no_parenthesis # Conflicts: # xdsl/parser.py
…xdslproject/xdsl into multiple_results_no_parenthesis # Conflicts: # xdsl/parser.py
@math-fehr sure, that's done and parser updated to reflect this too |
webmiche
approved these changes
Oct 26, 2022
mesham
force-pushed
the
multiple_results_no_parenthesis
branch
from
October 26, 2022 16:11
8534366
to
2a2ac0f
Compare
…xdslproject/xdsl into multiple_results_no_parenthesis # Conflicts: # xdsl/parser.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing MLIR format will not include parenthesis around multiple results to fix MLIR parsing error