Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIR target does not include parenthesis around multiple results to f… #209

Merged
merged 11 commits into from Oct 26, 2022

Conversation

mesham
Copy link
Contributor

@mesham mesham commented Oct 24, 2022

When printing MLIR format will not include parenthesis around multiple results to fix MLIR parsing error

@math-fehr
Copy link
Collaborator

Thanks, that looks good!
Can you change it for xDSL as well? I think we should try to keep both notations the same here!

@mesham
Copy link
Contributor Author

mesham commented Oct 26, 2022

@math-fehr sure, that's done and parser updated to reflect this too

@mesham mesham force-pushed the multiple_results_no_parenthesis branch from 8534366 to 2a2ac0f Compare October 26, 2022 16:11
@mesham mesham merged commit c5e0d11 into main Oct 26, 2022
@kingiler kingiler deleted the multiple_results_no_parenthesis branch August 9, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants