Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpreter: (onnx) Add operations for ONNX model MNIST targeting #2341

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kayode-gif
Copy link
Collaborator

@kayode-gif kayode-gif commented Mar 17, 2024

resolves #2340

@kayode-gif kayode-gif self-assigned this Mar 17, 2024
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 89.62%. Comparing base (6be7662) to head (2bc8d87).
Report is 4 commits behind head on main.

Files Patch % Lines
xdsl/interpreters/onnx.py 80.80% 18 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2341      +/-   ##
==========================================
+ Coverage   89.56%   89.62%   +0.06%     
==========================================
  Files         337      339       +2     
  Lines       40450    40821     +371     
  Branches     6031     6064      +33     
==========================================
+ Hits        36230    36587     +357     
- Misses       3347     3352       +5     
- Partials      873      882       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kayode-gif kayode-gif changed the title interpreter: (onnx) add next batch of ops to interpret onnx model interpreter: (onnx) Add operations for ONNX model MNIST targeting Mar 18, 2024
@kayode-gif
Copy link
Collaborator Author

@superlopuh This is a bigger PR than normal, not so sure of some implementations such as reshape and maxpoolsingleout

@superlopuh
Copy link
Member

It would make it easier to review and approve each bit if you split them for sure

@kayode-gif
Copy link
Collaborator Author

It would make it easier to review and approve each bit if you split them for sure

sure, ill create seperate branches rn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interpreter: (onnx) Add operations to target MNIST ONNX model
2 participants