dialects: (dsp) add dsp dialect #2494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| %t1 = "arith.constant"() {"value" = 1 : i64}: () -> i64 | ||
| // CHECK: Operation does not verify: frame number of dimensions must be 1. Actual number of dimensions: 2 | ||
| %res_stft = "dsp.STFT"(%t0, %t1) {"frame_size" = 256 : i64, "hop_size" = 128 : i64}: (tensor<2x256xf32>, i64) -> tensor<2x128xf32> | ||
| } |
There was a problem hiding this comment.
Why is this added into the onnx folder and not into a new dsp folder?
There was a problem hiding this comment.
Yes, definitely the wrong place
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2494 +/- ##
==========================================
+ Coverage 89.78% 89.84% +0.05%
==========================================
Files 350 352 +2
Lines 43016 43969 +953
Branches 6394 6562 +168
==========================================
+ Hits 38622 39502 +880
- Misses 3447 3510 +63
- Partials 947 957 +10 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
May 2, 2024
|
Hi @alecerio, I'll close this PR for now, let's reopen it if you decide to pick up the project again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DSP dialect and STFT operation (with tests).
@zero9178 @math-fehr @compor