dialects: (memref_stream) Add an inits field to memref_stream.generic [1/3] #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
JosseVanDelm,
PapyChacal and
adutilleul
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2763 +/- ##
==========================================
- Coverage 89.81% 89.79% -0.02%
==========================================
Files 372 372
Lines 47817 47891 +74
Branches 7331 7353 +22
==========================================
+ Hits 42945 43004 +59
- Misses 3736 3743 +7
- Partials 1136 1144 +8 ☔ View full report in Codecov by Sentry. |
PapyChacal
reviewed
Jun 21, 2024
…ttom-up-constants
…ref_stream/const-init
AntonLydike
approved these changes
Jun 26, 2024
Comment on lines
+95
to
+108
| memref_stream.generic { | ||
| bounds = [#builtin.int<4>, #builtin.int<2>, #builtin.int<3>], | ||
| indexing_maps = [ | ||
| affine_map<(d0, d1, d2) -> (d0, d2)>, | ||
| affine_map<(d0, d1, d2) -> (d2, d1)>, | ||
| affine_map<(d0, d1) -> (d0, d1)> | ||
| ], | ||
| iterator_types = ["parallel", "parallel", "reduction"] | ||
| } ins(%E, %F : memref<4x2xf64>, memref<2x3xf64>) outs(%G : memref<4x3xf64>) inits(%H : f64) { | ||
| ^0(%e : f64, %f : f64, %acc_old : f64): | ||
| %prod = arith.mulf %e, %f : f64 | ||
| %acc_new = arith.addf %acc_old, %prod : f64 | ||
| linalg.yield %acc_new : f64 | ||
| } |
There was a problem hiding this comment.
nit: These filechecks don't actually test the inits added in this PR.
There was a problem hiding this comment.
This filecheck is just to check that we roundtrip correctly with printing and parsing of custom syntax, so I added a couple of ops with inits with them, there's no other functionality intended to test here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 1/3 that introduces constant initialisation to our kernel representations. This PR adds the new attribute, and adds NotImplemented to the streamification and lowering to loops, which are handled in the next two pull requests.
Note stacked PR.