Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Remove SSAValue construction from tests #324

Merged
merged 1 commit into from Jan 12, 2023

Conversation

webmiche
Copy link
Collaborator

This PR relpaces all SSAValue constructors with OpResult since SSAValue is an abstract base class, therefore it should not be instantiated ever.

closes #284

@webmiche webmiche added the testing PRs that modify tests label Jan 12, 2023
Copy link
Contributor

@tobiasgrosser tobiasgrosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to review this carefully. 😉

@tobiasgrosser tobiasgrosser added the hackathon To be tackled at the hackathon label Jan 12, 2023
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 90.18% // Head: 90.18% // No change to project coverage 👍

Coverage data is based on head (a3b6ff6) compared to base (63ef315).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          52       52           
  Lines        7149     7149           
  Branches     1176     1176           
=======================================
  Hits         6447     6447           
  Misses        460      460           
  Partials      242      242           
Impacted Files Coverage Δ
tests/dialects/test_memref.py 100.00% <100.00%> (ø)
tests/test_ssavalue.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@webmiche webmiche merged commit 1267d97 into main Jan 12, 2023
@webmiche webmiche deleted the michel/remove_ssa_value branch January 12, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackathon To be tackled at the hackathon testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: Do not use the SSAValue constructor while testing
3 participants