Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Refresh drafter #341

Merged
merged 1 commit into from Jan 20, 2023
Merged

CI: Refresh drafter #341

merged 1 commit into from Jan 20, 2023

Conversation

georgebisbas
Copy link
Contributor

No description provided.

@georgebisbas georgebisbas added the CI Continuous Integration label Jan 16, 2023
@georgebisbas georgebisbas self-assigned this Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023 •
edited

Codecov Report

Base: 88.49% // Head: 88.49% // No change to project coverage 👍

Coverage data is based on head (732e73d) compared to base (2846e92).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files          64       64           
  Lines        7847     7847           
  Branches     1285     1285           
=======================================
  Hits         6944     6944           
  Misses        645      645           
  Partials      258      258

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

math-fehr
math-fehr reviewed Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added two nits

.github/release-drafter.yml Outdated Show resolved Hide resolved
.github/release-drafter.yml
- 'dependencies'
- title: 'Miscellaneous'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those properties of commits?
I would say that these only makes sense during a PR, and should not be preserved in the logs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand this question? the labels are the github labels (?)

@georgebisbas georgebisbas force-pushed the tidy_drafter branch 3 times, most recently from 6d9ff05 to e1f510a Compare January 17, 2023 10:37
@superlopuh
Copy link
Member

Could you remind me what this does, please? Does it collect the logs for a release summary?

math-fehr
math-fehr approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@math-fehr math-fehr merged commit db421d7 into main Jan 20, 2023
@math-fehr math-fehr deleted the tidy_drafter branch January 20, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superlopuh superlopuh superlopuh approved these changes

@math-fehr math-fehr math-fehr approved these changes

@webmiche webmiche Awaiting requested review from webmiche

Assignees

@georgebisbas georgebisbas

Labels
CI Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@georgebisbas @superlopuh @math-fehr