dialects: Add support for returning multiple results using stencil.return #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
==========================================
- Coverage 88.64% 88.08% -0.57%
==========================================
Files 103 103
Lines 13900 14675 +775
Branches 2088 2211 +123
==========================================
+ Hits 12322 12926 +604
- Misses 1178 1330 +152
- Partials 400 419 +19
... and 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
georgebisbas
requested changes
Apr 3, 2023
webmiche
approved these changes
Apr 3, 2023
georgebisbas
approved these changes
Apr 3, 2023
superlopuh
approved these changes
Apr 3, 2023
AntonLydike
approved these changes
Apr 3, 2023
PapyChacal
pushed a commit
that referenced
this pull request
Apr 17, 2023
This PR intends to update the support for multiple stencil results. The [earlier version](#648) produced some bugs when lowered via Psyclone, this patch should not face a similar problem. Here's a [link](https://xdsl.zulipchat.com/#narrow/stream/362011-xDSL/topic/stencil.20dialect/near/346783038) to @mesham's original issue related to this. edit @georgebisbas : Also check: #659 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add support for returning and subsequent storing of multiple results using
stencil.return. More than one stencils can now be processed usingstencil.apply.