Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Region.block property for single-block Regions #743

Merged
merged 5 commits into from Apr 18, 2023

Conversation

tobiasgrosser
Copy link
Contributor

@tobiasgrosser tobiasgrosser commented Apr 18, 2023

This shortens the code needed to access the block in a single-block region and also documents the expectation that there is just a single block in the region.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 81.25% and no project coverage change.

Comparison is base (f9e6cd4) 87.43% compared to head (f90e239) 87.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #743   +/-   ##
=======================================
  Coverage   87.43%   87.44%           
=======================================
  Files         108      108           
  Lines       15840    15844    +4     
  Branches     2379     2379           
=======================================
+ Hits        13850    13854    +4     
  Misses       1556     1556           
  Partials      434      434           
Impacted Files Coverage Δ
xdsl/frontend/code_generation.py 0.00% <0.00%> (ø)
xdsl/transforms/lower_mpi.py 92.56% <ø> (ø)
xdsl/dialects/scf.py 90.19% <60.00%> (ø)
xdsl/dialects/builtin.py 82.25% <100.00%> (ø)
xdsl/ir.py 83.73% <100.00%> (+0.09%) ⬆️
.../transforms/experimental/ConvertStencilToLLMLIR.py 96.53% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tobiasgrosser tobiasgrosser added API Related to changes regarding API of constructs core xDSL core (ir, textual format, ...) labels Apr 18, 2023
@tobiasgrosser tobiasgrosser changed the title Introduce region block Add Region.block property for single-block Regions Apr 18, 2023
@tobiasgrosser tobiasgrosser requested review from webmiche, math-fehr and AntonLydike and removed request for webmiche April 18, 2023 06:36
@tobiasgrosser tobiasgrosser merged commit ee25515 into main Apr 18, 2023
14 checks passed
@tobiasgrosser tobiasgrosser deleted the introduce_region_block branch April 18, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to changes regarding API of constructs core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants