Support more serialization data types + Fixed out of memory issue #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
necosta
commented
May 25, 2023
| @@ -24,19 +24,16 @@ object ScalaSerialDescriptor: | |||
|
|
|||
| private inline def getSerialDescriptor[T <: Tuple]: List[SerialDescriptor] = inline erasedValue[T] match | |||
| case _: EmptyTuple => Nil | |||
| case _: (h *: t) => | |||
| summonInline[ClassTag[h]].runtimeClass match { | |||
There was a problem hiding this comment.
Did an analysis with a JVM profiler, this call was killing performance, creating OOM exceptions in some cases. A better look, we don't need this logic at all, we can just work with type matching.
necosta
changed the title
necosta
changed the title
necosta
changed the title
necosta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Option, List, Set and Map
still WIP, want to better understand why so much memory used on this logic.Performance improvement on ScalaSerialDescriptor, some out of memory issues seen on tests done by @Yawolf yesterday, should now be fixed.