Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create plugin for Scala publishing conventions #169

Merged
merged 5 commits into from
Jun 19, 2023

Conversation

franciscodr
Copy link
Contributor

This pull request creates a custom plugin to gather all the settings to publish Scala code to Maven Central. It includes:

  • Generate Javadoc jar from the output of the scaladoc task
  • Generate POM file
  • Sign the artifacts

juanpedromoreno
juanpedromoreno previously approved these changes Jun 7, 2023
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @franciscodr !

nomisRev
nomisRev previously approved these changes Jun 7, 2023
Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @franciscodr 🙌 Just one question/doubt.

@franciscodr franciscodr dismissed stale reviews from nomisRev and juanpedromoreno via ceda3b4 June 8, 2023 16:00
@nomisRev nomisRev merged commit ac09acf into main Jun 19, 2023
1 check passed
@nomisRev nomisRev deleted the scala-publishing-conventions branch June 19, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants