TokenTextSplitter Ref: extract method, use range. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diesalbla
force-pushed
the
ref_token_text_splitter
branch
3 times, most recently
from
c24450f
to
c4bf421
Compare
diesalbla
force-pushed
the
ref_token_text_splitter
branch
3 times, most recently
from
3b3b27c
to
5f83cb8
Compare
nomisRev
previously approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Nice refactor. Just 1 nit, and a suggestion
Thanks @diesalbla
core/src/commonMain/kotlin/com/xebia/functional/xef/textsplitters/TokenTextSplitter.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/com/xebia/functional/xef/textsplitters/TokenTextSplitter.kt
Outdated
Show resolved
Hide resolved
diesalbla
force-pushed
the
ref_token_text_splitter
branch
2 times, most recently
from
0919166
to
4ae7d77
Compare
Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
diesalbla
force-pushed
the
ref_token_text_splitter
branch
from
4ae7d77
to
a624070
Compare
nomisRev
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.