Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor API service in its own function #375

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

calvellido
Copy link
Contributor

Description

This PR just refactor the chatCompletions API functions into its own function, for a better code organization, reusage, and readability

It also tries to show actual errors that may come from the xef-server API, even if they incorrectly respond with 200 codes.

Copy link
Contributor

@javipacheco javipacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

Copy link
Contributor

@Montagon Montagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@javipacheco javipacheco merged commit dd71d31 into main Sep 4, 2023
5 checks passed
@javipacheco javipacheco deleted the calvellido-refactor-services branch September 4, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants