Kmp tokenizer #49
Merged
Kmp tokenizer #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscodr
reviewed
May 10, 2023
| scrape-it-browser-fetcher = { module = "it.skrape:skrapeit-browser-fetcher", version.ref = "scrapeit" } | ||
| scrape-it-async-fetcher = { module = "it.skrape:skrapeit-asyn-fetcher", version.ref = "scrapeit" } | ||
| jtokk-it = { module = "com.knuddels:jtokkit", version.ref = "jtokkit" } | ||
| skrape = { module = "it.skrape:skrapeit", version.ref = "scrapeit" } |
There was a problem hiding this comment.
Nit: Can we rename scrapeit to skrapeit in the version reference too?
franciscodr
reviewed
May 10, 2023
| import com.xebia.functional.tools.Agent | ||
|
|
||
| suspend fun search(vararg prompt: String): Array<out Agent> = | ||
| prompt | ||
| .map { | ||
| bingSearch( | ||
| search = it, | ||
| TokenTextSplitter(modelName = "gpt-3.5-turbo", chunkSize = 100, chunkOverlap = 50) | ||
| TokenTextSplitter(ModelType.GPT_3_5_TURBO, chunkSize = 100, chunkOverlap = 50) |
franciscodr
reviewed
May 10, 2023
Comment on lines
+53
to
+60
| * ```kotlin | ||
| * val encoding = EncodingType.CL100K_BASE.encoding | ||
| * encoding.encode("hello world", 100) | ||
| * // returns [15339, 1917] | ||
| * | ||
| * encoding.encode("hello <|endoftext|> world", 100) | ||
| * // raises an UnsupportedOperationException | ||
| * ``` |
There was a problem hiding this comment.
This example returns the same result as if we had called the encode function. It would be helpful to provide an example that will behave differently than if we used encode to show the difference between both functions.
franciscodr
approved these changes
May 10, 2023
|
Semi-blocked due to: https://youtrack.jetbrains.com/issue/KT-58678/Native-Regex-inconsistency-with-JVM-Native-Regex
|
…4k into KMP-tokenizer
|
This is ready for re-review @xebia-functional/team-ai. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a KMP tokenizer, ported from https://github.com/knuddelsgmbh/jtokkit. Excuse the 200k additions, but most of that are encodings..
It moves
TokenTextSplitterintocommonMainwith the new code.This was a quick spike to see if we could port it from Java to KMP, and it was quite easy based on a discussion yesterday with @raulraja.
@xebia-functional/team-ai