Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format violation reported by "Spotless" merging into main branch #491

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix format violation reported by "Spotless" merging into main branch #491

merged 1 commit into from
Oct 12, 2023

Conversation

tomascayuelas
Copy link
Contributor

@tomascayuelas tomascayuelas commented Oct 12, 2023 •
edited

Fix a violation reported by spotless.

My mistake I forgot to past this checks in local ;(

@tomascayuelas tomascayuelas self-assigned this Oct 12, 2023
@tomascayuelas tomascayuelas changed the title Fix format violation reported by spotless merging to main branch Fix format violation reported by "Spotless" merging into main branch Oct 12, 2023
@tomascayuelas tomascayuelas merged commit 77583b3 into main Oct 12, 2023
5 checks passed
@tomascayuelas tomascayuelas deleted the fix-format-violation branch October 12, 2023 17:09
@raulraja
Copy link
Contributor

The biggest issue is that spotless should have complained before we merged it into the main. The CI pipeline continues to be broken in that it lets in main code that does not get checked through spotless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Montagon Montagon Montagon approved these changes

@raulraja raulraja Awaiting requested review from raulraja

Assignees

@tomascayuelas tomascayuelas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomascayuelas @raulraja @Montagon