Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GRADLE_OPTS #70

Merged
merged 1 commit into from
May 17, 2023
Merged

Remove GRADLE_OPTS #70

merged 1 commit into from
May 17, 2023

Conversation

nomisRev
Copy link
Contributor

@nomisRev nomisRev commented May 17, 2023

Unrecognized VM option 'MaxPermSize=2048m'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Happened in Github actions trying to release Kotlin-loom, (https://github.com/xebia-functional/xef/actions/runs/4996510971/jobs/8949782026#step:4:96)

This PR removes GRADLE_OPTS since we don't need it in build so having it in the other files was a premature optimisation. Let's not add such options unless we need them for a good reason. @xebia-functional/team-ai

@franciscodr franciscodr merged commit 9437106 into main May 17, 2023
1 check passed
@franciscodr franciscodr deleted the remove-jvm-opts branch May 17, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants