-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixed in conversation #710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
previously approved these changes
Apr 2, 2024
javipacheco
commented
Apr 2, 2024
core/src/commonMain/kotlin/com/xebia/functional/xef/llm/MemoryManagement.kt
Show resolved
Hide resolved
javipacheco
commented
Apr 2, 2024
core/src/commonMain/kotlin/com/xebia/functional/xef/store/MemorizedMessage.kt
Show resolved
Hide resolved
javipacheco
commented
Apr 2, 2024
examples/src/main/kotlin/com/xebia/functional/xef/conversation/conversations/Animal.kt
Show resolved
Hide resolved
javipacheco
commented
Apr 2, 2024
examples/src/main/kotlin/com/xebia/functional/xef/conversation/conversations/Animal.kt
Show resolved
Hide resolved
javipacheco
commented
Apr 2, 2024
examples/src/main/kotlin/com/xebia/functional/xef/evaluator/TestExample.kt
Show resolved
Hide resolved
Montagon
previously approved these changes
Apr 2, 2024
core/src/commonMain/kotlin/com/xebia/functional/xef/store/MemorizedMessage.kt
Show resolved
Hide resolved
nomisRev
previously approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @javipacheco! 🙌
javipacheco
dismissed stale reviews from nomisRev, Montagon, and raulraja
via
April 2, 2024 14:36
4799494
Montagon
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some problems running the
Animal.kt
example in XefThe intention of
Animal.kt
is to demonstrate how Conversations work in Xef, and how it adds previous messages between the user and the assistant in the conversation.This example execute 4 calls to OpenAi using
ChatCompletions
.The most important thing is you don't need to add the previous messages. With these changes I have executed the example locally with the next result:
Animal:
Invention:
Story 1
Story 2:
For example, in
Story 1
we are calling to Xef using:Although we are not adding the
Axolotl
animal in the prompt, we can see this animal in theStory 1
I am going to add some comments in this PR to explain each problem I have encountered